Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #7

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Add documentation #7

merged 1 commit into from
Apr 26, 2020

Conversation

pascalberger
Copy link
Member

Adds documentation for the addin for inclusion in https://cakeissues.net/.

Features need to be updated to match the actual implementation. Documentation in requirements.md assumes that requirements are listed in each release note entry on GitHub (which are imported into https://cakeissues.net/).

@janniksam I'll it up to you to update the PR to matching your implementation

@pascalberger
Copy link
Member Author

Once this is merged and a first (pre)-release is available on nuget.org documentation can be added to https://cakeissues.net with cake-contrib/Cake.Issues.Website#139

Copy link
Contributor

@janniksam janniksam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, this looks fine

Copy link
Member Author

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supported IIssue properties are not correct yet. I'll update them based on your implementation

docs/features.md Outdated Show resolved Hide resolved
docs/features.md Outdated Show resolved Hide resolved
docs/features.md Outdated Show resolved Hide resolved
docs/features.md Outdated Show resolved Hide resolved
docs/features.md Outdated Show resolved Hide resolved
docs/features.md Outdated Show resolved Hide resolved
docs/features.md Outdated Show resolved Hide resolved
Title: Requirements
Description: Requirements for the Cake.Issues.DupFinder addin.
---
The requirements for using the [Cake.Issues.DupFinder addin] are listed in the [release notes] for any specific version.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this OK for you to mention the requirement in release notes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure on what the requirement are except Cake.Issues and the JetBrains commandline tools.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addins are built against a specific API of Cake, in this case also a specific API of Cake.Issues and have requirements for target Framework. See e.g. the requirements section for Cake.Issues.InspectCode:

Requirements
- Cake 0.33.0 or higher
- Cake.Issues 0.8.x
- Targeting .NET Standard 2.0 and .NET Framework 4.6.1

@pascalberger
Copy link
Member Author

@janniksam I updated the feature page based on your implementation. Please have another look if it is OK now

@janniksam
Copy link
Contributor

Can you give me a short description on how these files will be used? Are they part of a specific tool or are they automatically taken and shown somewhere? Is there a process behind all this?

@pascalberger
Copy link
Member Author

cake-contrib/Cake.Issues.Website#139 will use them to integrate into https://cakeissues.net. See docs folder of Cake.Issues.InspectCode which is rendered on https://cakeissues.net/docs/issue-providers/inspectcode/. Rendering / integration is done in the build script of the Cake.Issues.Website repo.

If you prefer to not have it added to https://cakeissues.net this would also be fine for me.

@janniksam
Copy link
Contributor

cake-contrib/Cake.Issues.Website#139 will use them to integrate into https://cakeissues.net. See docs folder of Cake.Issues.InspectCode which is rendered on https://cakeissues.net/docs/issue-providers/inspectcode/. Rendering / integration is done in the build script of the Cake.Issues.Website repo.

If you prefer to not have it added to https://cakeissues.net this would also be fine for me.

That is totally fine with me. 👍

I am just a bit overwhelmed right now by all these new technologies. A lot of magic happening in the background. Hopefully I will get into that pretty quickly, the release process (versioning etc) is still a big question for me.

But I'll contact you with my questions on gitter, if I have more. This is the wrong place ;-)

@pascalberger
Copy link
Member Author

Sure just hit me up on Twitter and we can walk together through versioning / release

@janniksam
Copy link
Contributor

Can this be merged now? We could give some more details about the issue, for example that ProjectName and ProjectFileRelativePath are never filled.

@pascalberger
Copy link
Member Author

OK for me to merge it. It's currently in sync with the documentation of other issue providers which showning a red "x" for properties which are not filled (like here).

@janniksam janniksam merged commit a1c5b70 into develop Apr 26, 2020
@janniksam janniksam deleted the feature/doc branch April 26, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants