Merge branch 'release/4.4.0'

cake-contrib · May 20, 2024 · f922edf · f922edf
2 parents 496d2f9 + 70eb539
commit f922edf
Show file tree

Hide file tree

Showing 45 changed files with 77 additions and 119 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -7,7 +7,7 @@ jobs:
  runs-on: windows-2022
  steps:
  - name: Get the sources
- uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4
+ uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4
  - name: Fetch all tags and branches
  run: git fetch --prune --unshallow
  - name: Install .NET
@@ -34,7 +34,7 @@ jobs:
  runs-on: windows-2019
  steps:
  - name: Get the sources
- uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4
+ uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4
  - name: Install required tools
  run: npm install -g markdownlint-cli
  shell: powershell

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/AppVeyorBuildServer.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/AppVeyorBuildServer.cs
@@ -3,10 +3,6 @@ namespace Cake.Frosting.Issues.Recipe
  using Cake.Common.Build;
  using Cake.Common.IO;
  using Cake.Core.IO;
- using Cake.Issues;
- using Cake.Issues.PullRequests;
- using Cake.Issues.PullRequests.AppVeyor;
- using System;
 
  /// <summary>
  /// Support for AppVeyor builds.

diff --git a/...Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/AzureDevOpsBuildServer.cs b/...Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/AzureDevOpsBuildServer.cs
@@ -5,11 +5,6 @@ namespace Cake.Frosting.Issues.Recipe
  using Cake.Common.Build.AzurePipelines.Data;
  using Cake.Common.IO;
  using Cake.Core.IO;
- using Cake.Issues;
- using Cake.Issues.Reporting;
- using Cake.Issues.Reporting.Generic;
- using System;
- using System.IO;
 
  /// <summary>
  /// Support for Azure DevOps / Azure Pipelines builds.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/BaseBuildServer.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/BaseBuildServer.cs
@@ -1,8 +1,6 @@
 namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Core.IO;
- using Cake.Issues;
- using System;
 
  /// <summary>
  /// Basic implementation for all build servers.

diff --git a/...osting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/GitHubActionsBuildServer.cs b/...osting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/GitHubActionsBuildServer.cs
@@ -2,10 +2,6 @@ namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Common.Build;
  using Cake.Core.IO;
- using Cake.Issues;
- using Cake.Issues.PullRequests;
- using Cake.Issues.PullRequests.GitHubActions;
- using System;
 
  /// <summary>
  /// Support for builds running on GitHub Actions.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/IIssuesBuildServer.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/BuildServers/IIssuesBuildServer.cs
@@ -1,7 +1,6 @@
 namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Core.IO;
- using System;
 
  /// <summary>
  /// Description of a build server implementation.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.csproj b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.csproj
@@ -3,6 +3,7 @@
  <PropertyGroup>
  <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
  <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\Cake.Frosting.Issues.Recipe.xml</DocumentationFile>
+ <ImplicitUsings>enable</ImplicitUsings>
  <EnableNETAnalyzers>true</EnableNETAnalyzers>
  <AnalysisMode>AllEnabledByDefault</AnalysisMode>
  </PropertyGroup>
@@ -24,7 +25,7 @@ For recipe compatible with Cake Script Runners see Cake.Issues.Recipe.</Descript
  <PackageLicenseExpression>MIT</PackageLicenseExpression>
  <RepositoryType>git</RepositoryType>
  <RepositoryUrl>https://github.com/cake-contrib/Cake.Issues.Recipe.git</RepositoryUrl>
- <PackageReleaseNotes>https://github.com/cake-contrib/Cake.Issues.Recipe/releases/tag/4.3.1</PackageReleaseNotes>
+ <PackageReleaseNotes>https://github.com/cake-contrib/Cake.Issues.Recipe/releases/tag/4.4.0</PackageReleaseNotes>
  </PropertyGroup>
 
  <ItemGroup>
@@ -33,24 +34,26 @@ For recipe compatible with Cake Script Runners see Cake.Issues.Recipe.</Descript
 
  <ItemGroup>
  <None Include="icon.png" Pack="true" PackagePath="\" />
+ <None Include="Cake.Frosting.Issues.Recipe.targets" Pack="true" PackagePath="build" />
+ <None Include="Cake.Frosting.Issues.Recipe.targets" Pack="true" PackagePath="buildTransitive" />
  </ItemGroup>
 
  <ItemGroup>
  <PackageReference Include="Cake.AzureDevOps" Version="4.0.0" />
  <PackageReference Include="Cake.Frosting" Version="4.0.0" PrivateAssets="All" />
  <PackageReference Include="Cake.Frosting.Git" Version="4.0.0" />
- <PackageReference Include="Cake.Issues" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.EsLint" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.InspectCode" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.Markdownlint" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.MsBuild" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.PullRequests" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.PullRequests.AppVeyor" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.PullRequests.AzureDevOps" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.PullRequests.GitHubActions" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.Reporting" Version="4.3.1" />
- <PackageReference Include="Cake.Frosting.Issues.Reporting.Sarif" Version="4.3.1" /> 
- <PackageReference Include="Cake.Frosting.Issues.Reporting.Generic" Version="4.3.1" />
+ <PackageReference Include="Cake.Issues" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.EsLint" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.InspectCode" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.Markdownlint" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.MsBuild" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.PullRequests" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.PullRequests.AppVeyor" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.PullRequests.AzureDevOps" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.PullRequests.GitHubActions" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.Reporting" Version="4.4.0" />
+ <PackageReference Include="Cake.Frosting.Issues.Reporting.Sarif" Version="4.4.0" /> 
+ <PackageReference Include="Cake.Frosting.Issues.Reporting.Generic" Version="4.4.0" />
  </ItemGroup>
 
 </Project>
diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.targets b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.targets
@@ -0,0 +1,5 @@
+<Project>
+ <ItemGroup Condition="'$(Language)' == 'C#' AND ('$(ImplicitUsings)' == 'true' or '$(ImplicitUsings)' == 'enable')">
+ <Using Include="Cake.Frosting.Issues.Recipe" />
+ </ItemGroup>
+</Project>
diff --git a/...ng.Issues.Recipe/Cake.Frosting.Issues.Recipe/Context/IssuesContext{TParameters,TState}.cs b/...ng.Issues.Recipe/Cake.Frosting.Issues.Recipe/Context/IssuesContext{TParameters,TState}.cs
@@ -2,7 +2,6 @@
 {
  using Cake.Common.Diagnostics;
  using Cake.Core;
- using System;
  using System.Diagnostics;
  using System.Reflection;
 

diff --git a/...sues.Recipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IIssuesParametersInputFiles.cs b/...sues.Recipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IIssuesParametersInputFiles.cs
@@ -1,8 +1,6 @@
 namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Core.IO;
- using Cake.Issues;
- using System.Collections.Generic;
 
  /// <summary>
  /// Parameters for passing input files.

diff --git a/...cipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IIssuesParametersPullRequestSystem.cs b/...cipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IIssuesParametersPullRequestSystem.cs
@@ -1,9 +1,5 @@
 namespace Cake.Frosting.Issues.Recipe
 {
- using Cake.Issues;
- using Cake.Issues.PullRequests;
- using System.Collections.Generic;
-
  /// <summary>
  /// Parameters for pull request integration.
  /// </summary>
@@ -53,6 +49,11 @@ public interface IIssuesParametersPullRequestSystem
  /// </summary>
  Dictionary<string, IProviderIssueLimits> ProviderIssueLimits { get; }
 
+ /// <summary>
+ /// Gets list of filter functions which should be applied before posting issues to pull requests.
+ /// </summary>
+ IList<Func<IEnumerable<IIssue>, IEnumerable<IIssue>>> IssueFilters { get; }
+
  /// <summary>
  /// Gets or sets a value indicating whether a status on the pull request should be set if there are any issues found.
  /// The status is succeeded if there are no issues and fails as soon as issues from any issue provider or run have been found.

diff --git a/...ssues.Recipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IIssuesParametersReporting.cs b/...ssues.Recipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IIssuesParametersReporting.cs
@@ -1,7 +1,5 @@
 namespace Cake.Frosting.Issues.Recipe
 {
- using Cake.Issues.Reporting.Generic;
-
  /// <summary>
  /// Parameters for reporting.
  /// </summary>

diff --git a/...ssues.Recipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IssuesParametersInputFiles.cs b/...ssues.Recipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IssuesParametersInputFiles.cs
@@ -1,8 +1,6 @@
 namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Core.IO;
- using Cake.Issues;
- using System.Collections.Generic;
 
  /// <summary>
  /// Parameters for passing input files.

diff --git a/...ecipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IssuesParametersPullRequestSystem.cs b/...ecipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IssuesParametersPullRequestSystem.cs
@@ -1,8 +1,5 @@
 namespace Cake.Frosting.Issues.Recipe
 {
- using Cake.Issues.PullRequests;
- using System.Collections.Generic;
-
  /// <summary>
  /// Parameters for pull request integration.
  /// </summary>
@@ -28,5 +25,8 @@ public class IssuesParametersPullRequestSystem : IIssuesParametersPullRequestSys
 
  /// <inheritdoc />
  public Dictionary<string, IProviderIssueLimits> ProviderIssueLimits => new();
+
+ /// <inheritdoc />
+ public IList<Func<IEnumerable<IIssue>, IEnumerable<IIssue>>> IssueFilters => [];
  }
 }
diff --git a/...Issues.Recipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IssuesParametersReporting.cs b/...Issues.Recipe/Cake.Frosting.Issues.Recipe/Context/Parameters/IssuesParametersReporting.cs
@@ -1,7 +1,5 @@
 namespace Cake.Frosting.Issues.Recipe
 {
- using Cake.Issues.Reporting.Generic;
-
  /// <summary>
  /// Parameters for reporting.
  /// </summary>

diff --git a/...xt/Parameters/IssuesParameters{TInputFiles,TReporting,TBuildServer,TPullRequestSystem}.cs b/...xt/Parameters/IssuesParameters{TInputFiles,TReporting,TBuildServer,TPullRequestSystem}.cs
@@ -1,7 +1,6 @@
 namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Core.IO;
- using System;
 
  /// <summary>
  /// Parameters of the build.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/Context/State/IIssuesState.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/Context/State/IIssuesState.cs
@@ -1,9 +1,6 @@
 namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Core.IO;
- using Cake.Issues;
- using System;
- using System.Collections.Generic;
 
  /// <summary>
  /// Description of the mutable state of the build run.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/Context/State/IssuesState.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/Context/State/IssuesState.cs
@@ -5,9 +5,6 @@
  using Cake.Common.Diagnostics;
  using Cake.Common.IO;
  using Cake.Core.IO;
- using Cake.Issues;
- using System;
- using System.Collections.Generic;
 
  /// <summary>
  /// Mutable state of the build run.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/CreateFullIssuesReportTask.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/CreateFullIssuesReportTask.cs
@@ -1,9 +1,6 @@
 namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Common.IO;
- using Cake.Issues;
- using Cake.Issues.Reporting;
- using Cake.Issues.Reporting.Generic;
 
  /// <summary>
  /// Creates issue report.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/CreateSarifReportTask.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/CreateSarifReportTask.cs
@@ -1,9 +1,6 @@
 namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Common.IO;
- using Cake.Issues;
- using Cake.Issues.Reporting;
- using Cake.Issues.Reporting.Sarif;
 
  /// <summary>
  /// Creates issue report in SARIF format.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/CreateSummaryIssuesReportTask.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/CreateSummaryIssuesReportTask.cs
@@ -2,7 +2,6 @@
 {
  using Cake.Common.Build;
  using Cake.Common.Diagnostics;
- using Cake.Issues;
 
  /// <summary>
  /// Creates a summary issue report.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/PublishIssuesArtifactsTask.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/PublishIssuesArtifactsTask.cs
@@ -2,7 +2,6 @@
 {
  using Cake.Common.Build;
  using Cake.Common.Diagnostics;
- using Cake.Issues;
 
  /// <summary>
  /// Publish issue artifacts to build server.

diff --git a/...ues.Recipe/Cake.Frosting.Issues.Recipe/PullRequestSystems/AzureDevOpsPullRequestSystem.cs b/...ues.Recipe/Cake.Frosting.Issues.Recipe/PullRequestSystems/AzureDevOpsPullRequestSystem.cs
@@ -4,11 +4,6 @@ namespace Cake.Frosting.Issues.Recipe
  using Cake.AzureDevOps.Repos.PullRequest;
  using Cake.Common;
  using Cake.Common.Diagnostics;
- using Cake.Issues;
- using Cake.Issues.PullRequests;
- using Cake.Issues.PullRequests.AzureDevOps;
- using System.Collections.Generic;
- using System.Linq;
 
  /// <summary>
  /// Support for Azure DevOps / Azure Repository hosted code.

diff --git a/...ing.Issues.Recipe/Cake.Frosting.Issues.Recipe/PullRequestSystems/BasePullRequestSystem.cs b/...ing.Issues.Recipe/Cake.Frosting.Issues.Recipe/PullRequestSystems/BasePullRequestSystem.cs
@@ -1,8 +1,5 @@
 namespace Cake.Frosting.Issues.Recipe
 {
- using Cake.Issues;
- using Cake.Issues.PullRequests;
-
  /// <summary>
  /// Basic implementation for all pull request server.
  /// </summary>
@@ -40,6 +37,11 @@ protected static IReportIssuesToPullRequestSettings GetReportIssuesToPullRequest
  settings.ProviderIssueLimits.Add(providerIssueLimit.Key, providerIssueLimit.Value);
  }
 
+ foreach (var issueFilter in context.Parameters.PullRequestSystem.IssueFilters)
+ {
+ settings.IssueFilters.Add(issueFilter);
+ }
+
  return settings;
  }
  }

diff --git a/...g.Issues.Recipe/Cake.Frosting.Issues.Recipe/PullRequestSystems/GitHubPullRequestSystem.cs b/...g.Issues.Recipe/Cake.Frosting.Issues.Recipe/PullRequestSystems/GitHubPullRequestSystem.cs
@@ -1,7 +1,5 @@
 namespace Cake.Frosting.Issues.Recipe
 {
- using Cake.Issues;
-
  /// <summary>
  /// Support for GitHub hosted code.
  /// </summary>

diff --git a/....Issues.Recipe/Cake.Frosting.Issues.Recipe/PullRequestSystems/IIssuesPullRequestSystem.cs b/....Issues.Recipe/Cake.Frosting.Issues.Recipe/PullRequestSystems/IIssuesPullRequestSystem.cs
@@ -1,7 +1,5 @@
 namespace Cake.Frosting.Issues.Recipe
 {
- using Cake.Issues;
-
  /// <summary>
  /// Description of a pull request system implementation.
  /// </summary>

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/ReadIssuesTask.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/ReadIssuesTask.cs
@@ -1,12 +1,6 @@
 namespace Cake.Frosting.Issues.Recipe
 {
  using Cake.Common.Diagnostics;
- using Cake.Issues;
- using Cake.Issues.EsLint;
- using Cake.Issues.InspectCode;
- using Cake.Issues.Markdownlint;
- using Cake.Issues.MsBuild;
- using System.Linq;
 
  /// <summary>
  /// Reads issues from the provided log files.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/ReportIssuesToBuildServerTask.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/ReportIssuesToBuildServerTask.cs
@@ -2,7 +2,6 @@
 {
  using Cake.Common.Build;
  using Cake.Common.Diagnostics;
- using Cake.Issues;
 
  /// <summary>
  /// Report issues to build server.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/ReportIssuesToPullRequestTask.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/ReportIssuesToPullRequestTask.cs
@@ -2,7 +2,6 @@
 {
  using Cake.Common.Build;
  using Cake.Common.Diagnostics;
- using Cake.Issues;
 
  /// <summary>
  /// Report issues to build server.

diff --git a/...Issues.Recipe/Cake.Frosting.Issues.Recipe/RepositoryInfo/CakeGitRepositoryInfoProvider.cs b/...Issues.Recipe/Cake.Frosting.Issues.Recipe/RepositoryInfo/CakeGitRepositoryInfoProvider.cs
@@ -3,9 +3,6 @@
  using Cake.Core;
  using Cake.Core.IO;
  using Cake.Git;
- using Cake.Issues;
- using System;
- using System.Linq;
 
  /// <summary>
  /// Provider to retrieve repository information using <see href="https://cakebuild.net/extensions/cake-git/">Cake.Git addin</see>.

diff --git a/...ing.Issues.Recipe/Cake.Frosting.Issues.Recipe/RepositoryInfo/CliRepositoryInfoProvider.cs b/...ing.Issues.Recipe/Cake.Frosting.Issues.Recipe/RepositoryInfo/CliRepositoryInfoProvider.cs
@@ -3,10 +3,6 @@
  using Cake.Common;
  using Cake.Core;
  using Cake.Core.IO;
- using Cake.Issues;
- using System;
- using System.Collections.Generic;
- using System.Linq;
 
  /// <summary>
  /// Provider to retrieve repository information using Git CLI.

diff --git a/...sting.Issues.Recipe/Cake.Frosting.Issues.Recipe/RepositoryInfo/IRepositoryInfoProvider.cs b/...sting.Issues.Recipe/Cake.Frosting.Issues.Recipe/RepositoryInfo/IRepositoryInfoProvider.cs
@@ -2,7 +2,6 @@
 {
  using Cake.Core;
  using Cake.Core.IO;
- using System;
 
  /// <summary>
  /// Description of a provider to retrieve repository information.

diff --git a/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/SetPullRequestIssuesStateTask.cs b/Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe/SetPullRequestIssuesStateTask.cs
@@ -2,7 +2,6 @@
 {
  using Cake.Common.Build;
  using Cake.Common.Diagnostics;
- using Cake.Issues;
 
  /// <summary>
  /// Set pull request status.