Update dependency MSBuild.StructuredLogger to v2.2.243

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
MSBuild.StructuredLogger	2.2.235 -> 2.2.243

---

Release Notes

KirillOsenkov/MSBuildStructuredLog (MSBuild.StructuredLogger)

v2.2.243: 2.2.243: support binlog file format version 21

What's Changed

• Add support for improved TaskParameterEventArgs by @​ladipro in https://github.com/KirillOsenkov/MSBuildStructuredLog/pull/780

Full Changelog: KirillOsenkov/MSBuildStructuredLog@v2.2.240...v2.2.243

https://www.nuget.org/packages/binlogtool/1.0.15
https://www.nuget.org/packages/MSBuild.StructuredLogger/2.2.243

v2.2.240: 2.2.240: $copy project() to view project file copy graph

Supports $copy project() syntax to display all files copied by a given project(s).

Fix for #​736

Full Changelog: KirillOsenkov/MSBuildStructuredLog@v.2.2.235...v2.2.240

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

[pascalberger]

@KirillOsenkov Do you have an idea why it can't find Microsoft.Build.Utilities.Core 15.1.0.0 after update to 2.2.443 when running Unit Tests on .NET 6 on Windows? It works when running on .NET
7 or 8 or when running on .NET 6 on Linux and macOS.

With previous version KirillOsenkov/MSBuildStructuredLog#736 was an issue when running on Ubuntu, for which I had a workaround in place, which is now removed in this PR.

There is also the workaround mentioned in KirillOsenkov/MSBuildStructuredLog#692 (comment) still in place.

[pascalberger]

Issue with happens also with version 240 and is caused by this change KirillOsenkov/MSBuildStructuredLog@04ffca6 / issue KirillOsenkov/MSBuildStructuredLog#736

[KirillOsenkov]

Could this be the same as KirillOsenkov/MSBuildStructuredLog#692?

[KirillOsenkov]

You need to make sure the Microsoft.Build.Utilities.Core.dll ends up in the output directory for the test project when you build it.
KirillOsenkov/MSBuildStructuredLog#692 (comment)

[pascalberger]

You need to make sure the Microsoft.Build.Utilities.Core.dll ends up in the output directory for the test project when you build it. KirillOsenkov/MSBuildStructuredLog#692 (comment)

@KirillOsenkov Yes, seems to be a similar issue as KirillOsenkov/MSBuildStructuredLog#692, but the fix for this is still in place and assembly is in the output directory:

Cake.Issues/src/Cake.Issues.MsBuild/Cake.Issues.MsBuild.csproj

Lines 18 to 31 in 99fbc76

	<!--
	Workaround to make sure correct Microsoft.Build.Framework.dll version is copied to output for net6.0.
	Since it has a ref folder for netstandard2.0 and only target folder for net472 and net7.0, we need to copy it manually for net6.0.
	See https://github.com/KirillOsenkov/MSBuildStructuredLog/issues/692.
	-->
	<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
	<PackageReference Include="Microsoft.Build.Framework" Version="17.5.0" ExcludeAssets="all" PrivateAssets="all" GeneratePathProperty="true" />
	<PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.5.0" ExcludeAssets="all" PrivateAssets="all" GeneratePathProperty="true" />
	</ItemGroup>
	<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
	<Reference Include="$(PkgMicrosoft_Build_Framework)\lib\net472\Microsoft.Build.Framework.dll" />
	<Reference Include="$(PkgMicrosoft_Build_Utilities_Core)\lib\net472\Microsoft.Build.Utilities.Core.dll" />
	</ItemGroup>

The issue has returned with the fix for KirillOsenkov/MSBuildStructuredLog#736 in KirillOsenkov/MSBuildStructuredLog@04ffca6.

[KirillOsenkov]

From your logs:
Test run for D:\a\Cake.Issues\Cake.Issues\src\Cake.Issues.MsBuild.Tests\bin\Release\net6.0\Cake.Issues.MsBuild.Tests.dll (.NETCoreApp,Version=v6.0)

dotnet tool update -g lbi

As you can see, the file is present in bin\Debug\net7.0 and bin\Debug\net8.0, but not bin\Debug\net6.0. The 6.0 tests fail, predictably.

You need to make sure the file gets copied to the 6.0 directory.

[KirillOsenkov]

Your workaround works fine for Cake.Issues.MSBuild (as my screenshot shows), but you also need it for Cake.Issues.MSBuild.Tests.

Also notice how the file copied into C:\Cake.Issues\src\Cake.Issues.MsBuild\bin\Debug\net6.0\Microsoft.Build.Utilities.Core.dll is different from the one copied to the 7 and 8 output directories. My recommendation is to make sure you copy the same file.

[pascalberger]

Also notice how the file copied into C:\Cake.Issues\src\Cake.Issues.MsBuild\bin\Debug\net6.0\Microsoft.Build.Utilities.Core.dll is different from the one copied to the 7 and 8 output directories. My recommendation is to make sure you copy the same file.

@KirillOsenkov Thanks! Copying the files in unit test project fixed it. I'm copying the net472 assemblies for net6.0 since the net7.0 would result result in a dependency conflict with System.Runtime.

[KirillOsenkov]

Yes, this is right. Only need to copy for net6.0.