Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually embed the icon in the nuget package #46

Closed
gep13 opened this issue Jul 4, 2020 · 1 comment
Closed

Actually embed the icon in the nuget package #46

gep13 opened this issue Jul 4, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@gep13
Copy link
Member

gep13 commented Jul 4, 2020

In the 5.1.0 release, we tried to embed the icon into the nupkg, but this didn't work.

This is due to the fact that the build is happening on the Visual Studio 2017 image on AppVeyor, which uses an earlier version of .Net Core, and the dotnet pack silently doesn't actually pack the icon correctly.

Need to bump to the 2019 image.

@gep13 gep13 added the Bug label Jul 4, 2020
@gep13 gep13 added this to the 5.1.1 milestone Jul 4, 2020
@gep13 gep13 self-assigned this Jul 4, 2020
@gep13 gep13 closed this as completed Jul 4, 2020
gep13 added a commit that referenced this issue Jul 4, 2020
So that the package icon is correctly embedded into the package.
gep13 added a commit that referenced this issue Jul 4, 2020
* hotfix/5.1.1:
  (GH-46) Switch to 2019 base image on AppVeyor
gep13 added a commit that referenced this issue Jul 4, 2020
* hotfix/5.1.1:
  (GH-46) Switch to 2019 base image on AppVeyor
@cake-contrib-bot
Copy link

🎉 This issue has been resolved in version 5.1.1 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants