Skip to content

Commit

Permalink
(GH-259) Attempt to fix DAG
Browse files Browse the repository at this point in the history
Fix overriding of Task that was using the same name
  • Loading branch information
gep13 committed Oct 4, 2019
1 parent 25b104d commit d1ca04e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Cake.Recipe/Content/analyzing.cake
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ BuildParameters.Tasks.InspectCodeTask = Task("InspectCode")
})
);

BuildParameters.Tasks.InspectCodeTask = Task("CreateIssuesReport")
BuildParameters.Tasks.CreateIssuesReportTask = Task("CreateIssuesReport")
.IsDependentOn("InspectCode")
.Does<BuildData>(data => {
var issueReportFile = BuildParameters.Paths.Directories.TestResults.CombineWithFilePath("issues-report.html");
Expand Down
2 changes: 1 addition & 1 deletion Cake.Recipe/Content/appveyor.cake
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ BuildParameters.Tasks.PrintAppVeyorEnvironmentVariablesTask = Task("Print-AppVey

if (BuildSystem.IsRunningOnAppVeyor && !BuildParameters.IsNuGetBuild) {
BuildParameters.Tasks.ReportMessagesToCi = Task("Report-Messages-To-CI")
.IsDependentOn("InspectCode")
.IsDependentOn("CreateIssuesReport")
.IsDependeeOf("ContinuousIntegration")
.WithCriteria<BuildData>((context, data) => data.Issues.Any(), "No issues to report.")
.Does<BuildData>((data) =>
Expand Down
1 change: 1 addition & 0 deletions Cake.Recipe/Content/tasks.cake
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ public class BuildTasks
{
public CakeTaskBuilder DupFinderTask { get; set; }
public CakeTaskBuilder InspectCodeTask { get; set; }
public CakeTaskBuilder CreateIssuesReportTask { get; set; }
public CakeTaskBuilder AnalyzeTask { get; set; }
public CakeTaskBuilder PrintAppVeyorEnvironmentVariablesTask { get; set; }
public CakeTaskBuilder UploadArtifactsTask { get; set; }
Expand Down

0 comments on commit d1ca04e

Please sign in to comment.