Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish all artifacts to AppVeyor for PRs #62

Closed
pascalberger opened this issue Mar 16, 2017 · 7 comments · Fixed by #553
Closed

Publish all artifacts to AppVeyor for PRs #62

pascalberger opened this issue Mar 16, 2017 · 7 comments · Fixed by #553
Labels
Improvement
Milestone
2.0.0

Comments

@pascalberger
Copy link
Member

Currently only NuGet or Chocolatey packages are published to AppVeyor builds as artifacts.

Wouldn't it make sense to have other artifacts like Inspect Code or DupFinder results, Coverage and Test report also published as artifacts?
@gep13
Copy link
Member

gep13 commented Mar 16, 2017

@pascalberger yes, I think that would make sense.

@gep13 gep13 added this to the 2.0.0 milestone Sep 9, 2019
@gep13
Copy link
Member

gep13 commented Jul 9, 2020

@AdmiringWorm don't suppose you would have a list of files that you would like to see added as artifacts?

@gep13
Copy link
Member

gep13 commented Jul 9, 2020

Currently, this is what we upload:

image

@gep13
Copy link
Member

gep13 commented Jul 9, 2020

If there is one, the dupfinder report is being uploaded as well:

image

@AdmiringWorm
Copy link
Member

Looks like the code is missing the files for the coverage report generated by OpenCover, as well as test reports from MSBuild projects (don't remember if .NET Core projects generate test results).
But other than that I can't think of any, there could perhaps be some log files that could be useful, but can't think of any right now.

gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 10, 2020
@gep13
(cake-contribGH-62) Run Cake.Issues.Recipe entry task
ef75495 
This will result in the artifacts generated as part of the Issues build
to be uploaded as an artifact.
@gep13 gep13 mentioned this issue Jul 10, 2020
Merged
AdmiringWorm added a commit that referenced this issue Jul 10, 2020
@AdmiringWorm
Merge pull request #553 from gep13/feature/GH-62
d2403e0 
(GH-62) Run Cake.Issues.Recipe entry task
@gep13 gep13 reopened this Jul 10, 2020
@gep13
Copy link
Member

gep13 commented Jul 10, 2020

@AdmiringWorm apologies, didn't mean to have this one be closed. Think that there are still some artifacts that we should publish.

gep13 added a commit that referenced this issue Jul 10, 2020
@gep13
(GH-62) Fix order of task execution
921ef53 
Don't attempt to read issues until everything has been completed.
AdmiringWorm pushed a commit to gep13/Cake.Recipe that referenced this issue Jul 11, 2020
@gep13 @AdmiringWorm
(cake-contribGH-62) Fix order of task execution
b77edeb 
Don't attempt to read issues until everything has been completed.
@gep13
Copy link
Member

gep13 commented Aug 4, 2020

I have just had a look, and with the exception of the binlog, which we shouldn't ever publish, I think we have everything that we need for now:

image

If we need additional artifacts, we can add them as we go.

@gep13 gep13 closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-62) Run Cake.Issues.Recipe entry task gep13/Cake.Recipe
3 participants
@gep13 @AdmiringWorm @pascalberger