Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGit2 dll map do not get patched before running aliases related to Cake.Git #627

Closed
AdmiringWorm opened this issue Aug 17, 2020 · 1 comment

Comments

@AdmiringWorm
Copy link
Member

When the ability to detect whether the working directory is a repository was added, this ability was added before running the patching of the LibGit2 dll map.

On some Linux systems, this causes exceptions to happen and aborting the build due to the embedded libgit2 libraries included in the used addin is incompatible with the system, and have yet to be patched.

We need to move this patching to happen earlier, but at the same time, we can not move the patching away from GitVersion setup task (due to the restoring of the tool happens after Cake.Git is being used).

Alternatively we can change and move the code to copy the system dll to the necessary directories instead.

@AdmiringWorm
Copy link
Member Author

I think I will go with the issue #628 in favour of this one.
As long as the files get copied before any usage, there shouldn't be any problems (in theory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant