Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builds fail on Linux systems requiring a different version of LibGit2 when running under .NET Core cake #628

Closed
AdmiringWorm opened this issue Aug 17, 2020 · 0 comments · Fixed by #643
Closed

Builds fail on Linux systems requiring a different version of LibGit2 when running under .NET Core cake #628

AdmiringWorm opened this issue Aug 17, 2020 · 0 comments · Fixed by #643
Assignees
@AdmiringWorm
Labels
Improvement
Milestone
2.0.0

Comments

@AdmiringWorm
Copy link
Member

On some linux systems (like Arch Linux) the included libgit2 library used in Cake.Git and GitVersion are incompatible with the system, and a dll map can not be used when running under .NET Core.

Due to this we need to figure out how to deal with these scenarios, these could be dealt with by using symlink, hardlink or copy the files.
Symlinking and hardlinking won't work if the repository is located on a Network drive (may be other scenarios as well), so copying the file could be the best option.

This issue is related to #627 and may even replace it if we decide to copy/symlink or hardlink to all necessary locations.
@AdmiringWorm AdmiringWorm mentioned this issue Sep 1, 2020
Closed
@AdmiringWorm AdmiringWorm self-assigned this Sep 1, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Sep 2, 2020
@AdmiringWorm
(cake-contribGH-628) Copy system libgit2 files to cake.git and gitver…
cc77b34 
…sion directories

On some linux distros it is not possible to use
the embedded libgit2 binaries for these two
softwares, and as such they need to either be linked
or be copied to the necessary directories.
As we are moving toward better support regarding
.NET Core cake, we can no longer fully provide
the support of patch DLLMaps as these do not
work using .NET Core. As such this commit makes the
necessary changes to copy the system libgit2 library to the existing
libgit2*.so locactions underneeth the tools directory.
@AdmiringWorm AdmiringWorm added this to the 2.0.0 milestone Sep 2, 2020
@AdmiringWorm AdmiringWorm mentioned this issue Sep 2, 2020
Merged
gep13 pushed a commit to AdmiringWorm/Cake.Recipe that referenced this issue Sep 2, 2020
@AdmiringWorm @gep13
(cake-contribGH-628) Copy system libgit2 files to cake.git and gitver…
0ccd65f 
…sion directories

On some linux distros it is not possible to use
the embedded libgit2 binaries for these two
softwares, and as such they need to either be linked
or be copied to the necessary directories.
As we are moving toward better support regarding
.NET Core cake, we can no longer fully provide
the support of patch DLLMaps as these do not
work using .NET Core. As such this commit makes the
necessary changes to copy the system libgit2 library to the existing
libgit2*.so locactions underneeth the tools directory.
@gep13 gep13 closed this as completed in #643 Sep 2, 2020
gep13 added a commit that referenced this issue Sep 2, 2020
@gep13
Merge pull request #643 from AdmiringWorm/feature/gh-628
9e49d63 
(GH-628) Copy system libgit2 files to cake.git and gitversion directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-628) Copy system libgit2 files to cake.git and gitversion directories AdmiringWorm/Cake.Recipe
1 participant
@AdmiringWorm