-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagged commits on Hotfix branch do not use the correct semantic version number #719
Comments
codemonkey256
added a commit
to codemonkey256/Cake.Recipe
that referenced
this issue
Oct 26, 2020
…orrect semantic version number Hotfix and Release branches should use the unique semantic version number - implemented in (cake-contribGH-616). To fully implement as intended, the logic for applying the correct semantic version format needs to ensure that the 'is tagged' check is applied to each of the branch types.
AdmiringWorm
added a commit
that referenced
this issue
Oct 28, 2020
(GH-719) Tagged commits on Hotfix branch do not use the correct seman…
gep13
added a commit
that referenced
this issue
Nov 19, 2020
* release/2.1.0: (GH-725) Only look at top level folders (GH-716) Update ReportGenerator reference from 4.7.0 to 4.7.1 (GH-715) Update dotnet-reportgenerator-globaltool reference from 4.7.0 to 4.7.1 (GH-721) Further bump to 5.5.1 (GH-721) Update GitVersion.Tool reference from 5.3.7 to 5.5.0 (GH-719) Tagged commits on Hotfix branch do not use the correct semantic version number (doc) Fix up build command (GH-709) Update ReportGenerator reference from 4.6.7 to 4.7.0 (GH-710) Update dotnet-reportgenerator-globaltool reference from 4.6.7 to 4.7.0 (GH-702) Minor changes to docs (GH-702) added documentation for TeamCity
cake-contrib-bot
pushed a commit
that referenced
this issue
Nov 19, 2020
Merge branch 'release/2.1.0' * release/2.1.0: (GH-725) Only look at top level folders (GH-716) Update ReportGenerator reference from 4.7.0 to 4.7.1 (GH-715) Update dotnet-reportgenerator-globaltool reference from 4.7.0 to 4.7.1 (GH-721) Further bump to 5.5.1 (GH-721) Update GitVersion.Tool reference from 5.3.7 to 5.5.0 (GH-719) Tagged commits on Hotfix branch do not use the correct semantic version number (doc) Fix up build command (GH-709) Update ReportGenerator reference from 4.6.7 to 4.7.0 (GH-710) Update dotnet-reportgenerator-globaltool reference from 4.6.7 to 4.7.0 (GH-702) Minor changes to docs (GH-702) added documentation for TeamCity
🎉 This issue has been resolved in version 2.1.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
cake-contrib-bot
pushed a commit
that referenced
this issue
Nov 19, 2020
Merge branch 'release/2.1.0' * release/2.1.0: (GH-725) Only look at top level folders (GH-716) Update ReportGenerator reference from 4.7.0 to 4.7.1 (GH-715) Update dotnet-reportgenerator-globaltool reference from 4.7.0 to 4.7.1 (GH-721) Further bump to 5.5.1 (GH-721) Update GitVersion.Tool reference from 5.3.7 to 5.5.0 (GH-719) Tagged commits on Hotfix branch do not use the correct semantic version number (doc) Fix up build command (GH-709) Update ReportGenerator reference from 4.6.7 to 4.7.0 (GH-710) Update dotnet-reportgenerator-globaltool reference from 4.6.7 to 4.7.0 (GH-702) Minor changes to docs (GH-702) added documentation for TeamCity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The semantic version construction logic was updated in 3403262 with the intention that if the commit is on the Hotfix or Release branch but has not been tagged, then the new unique semantic version pattern should be used. Unfortunately, the current implementation only applies this correctly on the Release branch - the Hotfix branch will always use the unique semantic version regardless of whether it is tagged or not.
The text was updated successfully, but these errors were encountered: