Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to control KuduSync ignore list #992

Closed
gep13 opened this issue Aug 23, 2023 · 1 comment
Closed

Add ability to control KuduSync ignore list #992

gep13 opened this issue Aug 23, 2023 · 1 comment
Assignees
@gep13
Labels
Feature
Milestone
3.1.0

Comments

@gep13
Copy link
Member

gep13 commented Aug 23, 2023

Right now, it is not possible to control the ignore list that is used by KuduSync. This is hardcoded to:

Kudu.Sync(BuildParameters.Paths.Directories.PublishedDocumentation, publishFolder, new KuduSyncSettings {
    ArgumentCustomization = args=>args.Append("--ignore").AppendQuoted(".git;CNAME")
});

It should be possible to control this via a ToolSettings property, similar to what is done for other tools.
@gep13 gep13 added the Feature label Aug 23, 2023
@gep13 gep13 added this to the 3.1.0 milestone Aug 23, 2023
@gep13 gep13 self-assigned this Aug 23, 2023
@gep13 gep13 closed this as completed Aug 23, 2023
@cake-contrib-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gep13 added a commit that referenced this issue Aug 23, 2023
@gep13
(#992) Provide ability to set ignore of KuduSync
fce9759 
Rather than hard-coding the ignore list, here we have added a
ToolSettings property, which will allow this ignore list to be set
within the recipe.cake file, to control exactly what files are ignored
during a sync.

The default value of the ignore list remains the same as it was
previously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Feature
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@gep13 @cake-contrib-bot