Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-502) Set configuration during package restore #503

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

AdmiringWorm
Copy link
Member

The changes in this PR forces the dotnet restore command to restore packages using the configured Debug/Release configuration.

If this is not passed in, this can cause issues when a project have conditional package restoring (like only some packages should be restored during debugging, like packages hooking into the visual studio debugger which is not needed when producing a production build).

fixes #502

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit c57449c into cake-contrib:develop Jan 15, 2020
@gep13
Copy link
Member

gep13 commented Jan 15, 2020

@AdmiringWorm your changes have been merged, thanks for your contribution 👍

@AdmiringWorm AdmiringWorm deleted the bugfix/gh-502 branch January 15, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring packages for .NET Core only restores for debug builds
2 participants