Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-612) added a section on non-local build providers... #671

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

nils-a
Copy link
Contributor

@nils-a nils-a commented Sep 11, 2020

This is currently more a base for discussion.

I started out to make it more clear, that - if multiple builds are made - one buildprovider/os combination has to be "primary". Twoards that end, I added a section on "CI-systems" (i.e. non-local builds)

I sorted the section between Usage and Extending because

  • a) I felt that the top sections (Overview - Extending) are about "using" Cake.Recipe and the lower sections are more "other" stuff.
  • b) I felt that having multiple builds was more common than modifying builtin tasks 😊

Things I am uncertain about:

  • I don't like the title Overview in the overview.md but I had no better idea. Since the list of providers will never be really long, maybe could skip the overview page and add the more general informations direcly into index.cshtml.
  • I don't like the word "specifics" but I lack a better translation for the thing in my head. (Maybe 'idiosyncrasy'?) But then, the whole section is not necessary because the goal would be that all systems behave the same, right? (So the only specific (idiosyncrasy) would be that gh-actions currently lacks the ability to auto-upload the artifacts.)
  • On one hand I like the idea of having the build-yaml here for easy an start... On the other hand they are not really Cake.Recipe specific are they?

docs/input/docs/ci-systems/appveyor.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/github.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/github.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/github.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/overview.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/overview.md Outdated Show resolved Hide resolved
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small suggestions!

docs/input/docs/ci-systems/index.cshtml Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/github.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/github.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/github.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/azure.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/azure.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/appveyor.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/appveyor.md Outdated Show resolved Hide resolved
docs/input/docs/ci-systems/appveyor.md Outdated Show resolved Hide resolved
@gep13
Copy link
Member

gep13 commented Sep 12, 2020

@nils-a this is AMAZING! Thank you so much for pointing all this together, I really appreciate it! I left some comments for a few suggestions.

@nils-a
Copy link
Contributor Author

nils-a commented Sep 12, 2020

@gep13 I included your comments. I am still testing the example-builds provided here.

@nils-a
Copy link
Contributor Author

nils-a commented Sep 13, 2020

@gep13 @AdmiringWorm I have added the travis-example and made some modifications. Could you please have a renewd look at it? (And I promise, when we're done I'll squash the commit-jumble I have created here...)

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…lled CI-systems here), specifically pointing out that one provider/os-combination has to be marked "primus inter pares" using preferredBuildProviderType / preferredBuildAgentOperatingSystem. Also started on documenting the different (non-local) build providers.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 2de85a8 into cake-contrib:develop Sep 14, 2020
cake-contrib-bot pushed a commit that referenced this pull request Sep 14, 2020
Merge pull request #671 from nils-a/feature/GH-612

(GH-612) added a section on non-local build providers...
@nils-a nils-a deleted the feature/GH-612 branch September 14, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants