Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule URL resolver for CakeContrib-Guidelines #696

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Add rule URL resolver for CakeContrib-Guidelines #696

merged 1 commit into from
Oct 5, 2020

Conversation

pascalberger
Copy link
Member

Add rule URL resolver for CakeContrib-Guidelines rules. This allows to have a link to the rule documentation in the issue report.

gep13
gep13 approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 added this to the 2.0.0 milestone Oct 5, 2020
@gep13 gep13 added the Build label Oct 5, 2020
@gep13 gep13 merged commit 1e1224b into cake-contrib:develop Oct 5, 2020
@gep13 gep13 added Feature and removed Build labels Oct 5, 2020
@pascalberger pascalberger deleted the feature/guidelines-error-links branch October 5, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalberger @gep13