Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the output command #54

Merged
merged 13 commits into from
May 23, 2024

Conversation

david-obee
Copy link
Contributor

@david-obee david-obee commented Mar 20, 2020

Description

This PR adds support for the terraform output command, detailed in https://www.terraform.io/docs/commands/output.html.

Related Issue

#40

Motivation and Context

This is a useful command that has been missing. While similar results are achievable by interpreting the output of the terraform show command, this is much more straight forward to use if you only need output values.

How Has This Been Tested?

Covered the code with unit tests, as per the style of those for the other commands. All command line arguments used are tested.

This has been tested in a project Cake pipeline. A Terraform environment is created, after which we access two outputs using this new command.

Screenshots (if appropriate):

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@david-obee david-obee marked this pull request as ready for review March 20, 2020 18:06
Copy link

@megakid megakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@reda-chakkour
Copy link

@david-obee @megakid Any reason this never landed?

@david-obee
Copy link
Contributor Author

Hi @reda-chakkour, I'm not sure unfortunately, I don't have write access to the repo, so it needs one of the maintainers to approve and merge it

Copy link
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nils-a nils-a merged commit 073fbd3 into cake-contrib:develop May 23, 2024
@nils-a
Copy link
Contributor

nils-a commented May 23, 2024

@david-obee your changes have been merged, thanks for your contribution 👍

@nils-a nils-a linked an issue May 23, 2024 that may be closed by this pull request
@nils-a nils-a mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output Support
4 participants