Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-13) Add parameter for Chocolatey package ID #11

Merged
merged 1 commit into from
Dec 1, 2020
Merged

(GH-13) Add parameter for Chocolatey package ID #11

merged 1 commit into from
Dec 1, 2020

Conversation

pascalberger
Copy link
Member

@pascalberger pascalberger commented Nov 30, 2020 •
edited
Loading

Add support to overwrite the Chocolatey package ID

Fixes #13

gep13
gep13 requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Was there an issue for adding this support?

@pascalberger pascalberger changed the title Add parameter for Chocolatey package ID (GH-13) Add parameter for Chocolatey package ID Dec 1, 2020
@pascalberger
Copy link
Member Author

@gep13 Now it has 😉

@gep13 gep13 merged commit 4f6af51 into cake-contrib:develop Dec 1, 2020
@gep13
Copy link
Member

gep13 commented Dec 1, 2020

@pascalberger your changes have been merged, thanks for your contribution 👍

@pascalberger pascalberger deleted the feature/choco-package branch December 1, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add parameter for Chocolatey package ID
2 participants
@pascalberger @gep13