Cw 660 add ledger monero #1747
Open
Cw 660 add ledger monero #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…453-silent-payments
…MrCyjaneK-cyjan-monerodart � Conflicts: � cw_monero/lib/api/signatures.dart � cw_monero/lib/api/types.dart � cw_monero/lib/api/wallet_manager.dart � lib/locales/hausa_intl.dart � lib/locales/yoruba_intl.dart � lib/main.dart � macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme � scripts/android/pubspec_gen.sh
…MrCyjaneK-cyjan-monerodart � Conflicts: � lib/main.dart � lib/view_model/backup_view_model.dart
…ure cakewallet for iOS with for configuration script. Remove cw_shared configuration for cw_monero.
…, macOS, Windows.
…660-add-ledger-monero # Conflicts: # cw_monero/lib/api/wallet_manager.dart # cw_monero/lib/monero_wallet_service.dart # cw_monero/pubspec.lock # cw_monero/pubspec.yaml # cw_wownero/pubspec.lock # cw_wownero/pubspec.yaml # lib/router.dart # lib/src/screens/connect_device/debug_device_page.dart # lib/view_model/wallet_address_list/wallet_address_list_view_model.dart # lib/view_model/wallet_hardware_restore_view_model.dart # scripts/prepare_moneroc.sh
# Conflicts: # cw_bitcoin/lib/electrum_wallet.dart # cw_bitcoin/lib/electrum_wallet_addresses.dart # cw_bitcoin/lib/litecoin_wallet.dart # cw_bitcoin/lib/litecoin_wallet_addresses.dart # lib/view_model/dashboard/dashboard_view_model.dart # lib/view_model/wallet_list/wallet_list_view_model.dart # res/values/strings_de.arb
# Conflicts: # cw_bitcoin/lib/electrum_wallet.dart # cw_bitcoin/pubspec.lock
# Conflicts: # cw_bitcoin/lib/electrum_wallet.dart # cw_bitcoin/lib/electrum_wallet_addresses.dart # cw_bitcoin/lib/litecoin_wallet.dart # cw_bitcoin/lib/litecoin_wallet_addresses.dart # cw_bitcoin/pubspec.lock # lib/main.dart # lib/src/screens/connect_device/connect_device_page.dart # lib/src/screens/send/send_page.dart # lib/view_model/wallet_hardware_restore_view_model.dart # pubspec_base.yaml
OmarHatem28
requested changes
Nov 4, 2024
lib/src/screens/connect_device/monero_hardware_wallet_options_page.dart
Outdated
Show resolved
Hide resolved
| Navigator.of(context).pushNamed( | ||
| Routes.walletList, | ||
| arguments: (BuildContext context) => | ||
| Navigator.of(context).pushNamed(Routes.dashboard), |
There was a problem hiding this comment.
shouldn't this be pushAndRemoveUntil?
There was a problem hiding this comment.
Which one? the first push or the push to dashboard?
There was a problem hiding this comment.
the second one, push to dashboard, so that after the user goes to the dashboard, if he tapped back, he would get out of the app not go back to the wallet list page
OmarHatem28
reviewed
Nov 4, 2024
Comment on lines
+435
to
+442
| showPopUp<void>( | ||
| context: context, | ||
| builder: (BuildContext context) => AlertWithOneAction( | ||
| alertTitle: S.of(context).proceed_on_device, | ||
| alertContent: S.of(context).proceed_on_device_description, | ||
| buttonText: S.of(context).cancel, | ||
| buttonAction: () => Navigator.of(context).pop()), | ||
| ); |
There was a problem hiding this comment.
wouldn't this show up in normal wallets as well?
There was a problem hiding this comment.
Nope, requireHardwareWalletConnection is only true if it is a monero hardware wallet
There was a problem hiding this comment.
yes, but this is out of the if condition scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for ledger hardware wallets.
Pull Request - Checklist