attempt to implement support for cached keyset #600
Conversation
| "firebase/php-jwt": "^6.2", | ||
| "phpunit/phpunit": "^8.5 || ^9.3" | ||
| "phpunit/phpunit": "^8.5 || ^9.3", | ||
| "symfony/cache": "^5.4 || ^6.0" |
There was a problem hiding this comment.
Why do we need this dependency?
There was a problem hiding this comment.
see the discussion here:
this was rebased / reopened as github closed it beeing stale for a while.
There was a problem hiding this comment.
OK, so its the PSR6 vs PSR16 compatibility shims that we actually need. While I don't love the additional dependency I also don't relish maintaining adapter code for a low-frequency use feature. We'll should include the additional dependencies required in the documentation and raise an error with instructions to install the required dependencies if they don't exist.
| $jsonWebKeySet, | ||
| new Client(), | ||
| new RequestFactory(), | ||
| new Psr16Adapter(Cache::pool($jsonWebKeySetCache)), |
There was a problem hiding this comment.
Given that symfony/cache is an optional dependency the existence of the Psr16Adapter class should be checked first and in case of failure show a message stating which package the dev should include in their app.
|
This pull request is stale because it has been open 30 days with no activity. Remove the |
No description provided.