Fix small binary column creation #1000
Merged
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrations switched to cakephp/database we didn't have adequate test coverage for small non-standard sized blobs. This broke migrations that created small binary columns with indexes on them. By preserving the specific length for columns that are smaller than tinyblob we can preserve compatiblity with existing migrations. Fixes #999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrations switched to cakephp/database we didn't have adequate test coverage for small non-standard sized blobs. This broke migrations that created small binary columns with indexes on them. By preserving the specific length for columns that are smaller than tinyblob we can preserve compatibility with existing migrations.
Fixes #999