Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phinx 0.5.2 #205

Merged
merged 2 commits into from
Mar 4, 2016
Merged

Phinx 0.5.2 #205

merged 2 commits into from
Mar 4, 2016

Conversation

deizel
Copy link

@deizel deizel commented Mar 4, 2016

@HavokInspiration
Copy link
Member

I was working on adding support for 0.5.2 and implementing the new status output (and adding tests for it) as well as adding support for fulltext index for MySQL.

It is almost ready, I just have to tune the new build for MySQL 5.6 a bit to pass (since there is support for fulltext index on innodb only from 5.6 and upward and Travis runs 5.5 by default).

See the diff : master...HavokInspiration:phinx-0.5.2

HavokInspiration added a commit that referenced this pull request Mar 4, 2016
@HavokInspiration HavokInspiration merged commit cb8c82a into cakephp:master Mar 4, 2016
@HavokInspiration
Copy link
Member

Merged it. I'll build my additions on top of it.

@HavokInspiration HavokInspiration added this to the 1.5.8 milestone Mar 4, 2016
@deizel
Copy link
Author

deizel commented Mar 4, 2016

Thanks @HavokInspiration and sorry for jumping the gun - I had forked this and phinx to get some features I needed, so figured I would submit a PR instead of leaving it on my own fork. ;)

I had looked briefly at implementing getVersionLogs into the existing status command, but it seemed enough work to require it's own PR - glad to hear you are on it already! 👏

@deizel deizel deleted the phinx-0.5.2 branch March 4, 2016 18:36
@HavokInspiration
Copy link
Member

Don't worry, everything is going forward at the end of the day.

Out of curiosity, what features did you needed ?

@deizel
Copy link
Author

deizel commented Mar 4, 2016

Good stuff - for now it was the JSON data type and cakephp/phinx#768 to avoid hacks like this.

@HavokInspiration
Copy link
Member

Yes, I'm waiting for cakephp/phinx#768 as well.
If you need to, you can currently do it like this :

use Migrations\AbstractMigration;

class CreateProductsTable extends AbstractMigration
{

    public $autoId = false;

    public function up()
    {
        $table = $this->table('products');
        $table
            ->addColumn('id', 'integer', [
                'autoIncrement' => true,
                'signed' => false,
                'limit' => 11
            ])
            ->addPrimaryKey('id')
            ->addColumn('name', 'string')
            ->addColumn('description', 'text')
            ->create();
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants