Support phinx 0.15 requirement #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
force-pushed
the
support-phinx-0.15
branch
from
ae96b9e
to
f5407a2
Compare
othercorey
force-pushed
the
support-phinx-0.15
branch
2 times, most recently
from
14989a2
to
90f5e8c
Compare
|
I just changed the names to the new ones generated by the current phinx version for sqlite |
othercorey
force-pushed
the
support-phinx-0.15
branch
from
d3679d2
to
b870a63
Compare
othercorey
force-pushed
the
support-phinx-0.15
branch
from
b870a63
to
0636f98
Compare
|
Updated to require phinx 0.15.1 which fixes the PostgresAdapter. |
ndm2
reviewed
Sep 22, 2023
| * @param array $options Column Options | ||
| * @throws \InvalidArgumentException | ||
| * @return $this | ||
| */ | ||
| public function addColumn($columnName, $type = null, $options = []) | ||
| public function addColumn(Column|string $columnName, $type, $options = []) |
There was a problem hiding this comment.
I think the type should stay nullable, just like in cakephp/phinx#2218 (comment). When a Column object is provided, that object can hold the type.
There was a problem hiding this comment.
Ok, let's fix it then. I don't see this in function in my PR comments, but a couple nullable types were dropped because they seemed to only allow invalid text data (string name + null type).
|
@ndm2 Merging this version so it unblocks phinx 0.15.1 and your PR. We can update the signature with phin 0.15.2 as needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in PostgresAdapter::setConnection() where
useIdentityisn't initialized. Testing with branch until fix is released.cakephp/phinx#2223