Only include plugin tables (with files) in diff. #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Aug 6, 2025
The test now works correctly by: - Creating an initial migration to establish migration history - Running the migration to create proper phinxlog entries - Creating an empty schema dump for comparison - Adjusting assertions to match the modern migration format The test verifies that when using --plugin option, only tables with corresponding Table classes in the plugin are included in the diff.
dereuromark
force-pushed
the
4.next-diff
branch
from
1f85905 to
bb3ef26
Compare
Member
Author
|
should this target 4.next? |
Member
|
Just reading the code the filtering of the tables seems to similar to how it's done in Given the change in behavior it would be better to target this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #325
I gave claude.ai the following instructions
@ADmad What do you think?
In general this should probably be a flag/option of sorts, as this could be useful in both directions, and also for app (to exclude plugin ones?)