Remove null collate option from generated migrations #975
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When baking migration diffs, the collate option was included in column options even when null. This caused "collate is not a valid column option" errors when running migrations on PostgreSQL. Additionally, the collate to collation conversion was only done for MySQL and SQL Server. This caused the same error for PostgreSQL and SQLite columns with non-default collation. Fixes #974
dereuromark
force-pushed
the
fix-null-collate-option
branch
from
813ab71 to
f563323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
collateoption from column options inMigrationHelper::getColumnOption()Fixes #974