Skip to content

Commit

Permalink
Enable error php.ini directives in GH workflow (#2113)
Browse files Browse the repository at this point in the history
  • Loading branch information
MasterOdin authored Oct 9, 2022
1 parent f3e4259 commit 4664e27
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ jobs:
with:
php-version: ${{ matrix.php-version }}
coverage: pcov
ini-values: zend.assertions=1, error_reporting=-1, display_errors=On

- name: Get composer cache directory
id: composer-cache
Expand Down Expand Up @@ -146,7 +147,7 @@ jobs:
with:
php-version: ${{ env.PHP_VERSION }}
extensions: ${{ env.EXTENSIONS }}
ini-values: apc.enable_cli = 1, extension = php_fileinfo.dll
ini-values: apc.enable_cli=1, extension=php_fileinfo.dll, zend.assertions=1, error_reporting=-1, display_errors=On
coverage: pcov

- name: Setup SQLServer
Expand Down
4 changes: 2 additions & 2 deletions tests/Phinx/Console/Command/CreateTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public function testExecuteWithDuplicateMigrationNames()

$commandTester = new CommandTester($command);
$commandTester->execute(['command' => $command->getName(), 'name' => 'MyDuplicateMigration']);
sleep(1.01); // need at least a second due to file naming scheme
time_nanosleep(1, 100000); // need at least a second due to file naming scheme

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('The migration class name "MyDuplicateMigration" already exists');
Expand Down Expand Up @@ -181,7 +181,7 @@ public function testExecuteWithDuplicateMigrationNamesWithNamespace()

$commandTester = new CommandTester($command);
$commandTester->execute(['command' => $command->getName(), 'name' => 'MyDuplicateMigration']);
sleep(1.01); // need at least a second due to file naming scheme
time_nanosleep(1, 100000); // need at least a second due to file naming scheme

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('The migration class name "Foo\Bar\MyDuplicateMigration" already exists');
Expand Down

0 comments on commit 4664e27

Please sign in to comment.