Merge pull request #2257 from cakephp/fix-unset-properties

Fix fatal errors when calling get methods
cakephp · Jan 20, 2024 · c353796 · c353796
2 parents 5b42393 + 9de7d3e
commit c353796
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 0 deletions.
diff --git a/src/Phinx/Db/Table/Column.php b/src/Phinx/Db/Table/Column.php
@@ -212,6 +212,10 @@ public function setType(string|Literal $type)
  */
  public function getType(): string|Literal
  {
+ if (!isset($this->type)) {
+ throw new RuntimeException('Cannot access `type` it has not been set');
+ }
+
  return $this->type;
  }
 

diff --git a/src/Phinx/Db/Table/ForeignKey.php b/src/Phinx/Db/Table/ForeignKey.php
@@ -96,6 +96,10 @@ public function setReferencedTable(Table $table)
  */
  public function getReferencedTable(): Table
  {
+ if (!isset($this->referencedTable)) {
+ throw new RuntimeException('Cannot access `referencedTable` it has not been set');
+ }
+
  return $this->referencedTable;
  }
 

diff --git a/tests/Phinx/Db/Table/ColumnTest.php b/tests/Phinx/Db/Table/ColumnTest.php
@@ -20,6 +20,13 @@ public function testSetOptionThrowsExceptionIfOptionIsNotString()
  $column->setOptions(['identity']);
  }
 
+ public function testGetType()
+ {
+ $column = new Column();
+ $this->expectException(RuntimeException::class);
+ $column->getType();
+ }
+
  public function testSetOptionsIdentity()
  {
  $column = new Column();

diff --git a/tests/Phinx/Db/Table/ForeignKeyTest.php b/tests/Phinx/Db/Table/ForeignKeyTest.php
@@ -34,6 +34,12 @@ public function testInitiallyActionsEmpty()
  $this->assertNull($this->fk->getOnUpdate());
  }
 
+ public function testRefrencedTableUndefined()
+ {
+ $this->expectException(RuntimeException::class);
+ $this->fk->getReferencedTable();
+ }
+
  /**
  * @param string $dirtyValue
  * @param string $valueOfConstant