Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill up column values from schema #1155

Merged
merged 2 commits into from
Aug 30, 2017

Conversation

garex
Copy link
Contributor

@garex garex commented Aug 25, 2017

When we create enum's in DB we should be able to read their's values back in migrations too.

@lorenzo
Copy link
Member

lorenzo commented Aug 25, 2017

Tests are failing

@garex garex force-pushed the fill-up-column-values-from-schema branch from 43a23a7 to aab8e2f Compare August 26, 2017 19:05
@garex
Copy link
Contributor Author

garex commented Aug 26, 2017

rebased on latest master, fixed and forced back

* Document `getSqlType` call from `getPhinxType`
@garex garex force-pushed the fill-up-column-values-from-schema branch from aab8e2f to 8b46624 Compare August 26, 2017 19:08
@lorenzo
Copy link
Member

lorenzo commented Aug 30, 2017

Thanks!

@lorenzo lorenzo merged commit 72e1533 into cakephp:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants