Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set column null by default unless identity #1872

Merged
merged 8 commits into from
Sep 28, 2020
Merged

Set column null by default unless identity #1872

merged 8 commits into from
Sep 28, 2020

Conversation

MasterOdin
Copy link
Member

Closes #1817

This makes it so that newly added columns are NULL by default, instead of NOT NULL except in the case of a column that uses the identity option, and does not also set a null option.

This is definitely BC breaking, and the release notes should make a big note that all previously written migrations will have to be updated to take into account the new null default, unless the authors were already explicit about the null status within their migrations.

MasterOdin and others added 7 commits August 26, 2020 00:28
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
@MasterOdin MasterOdin changed the title Column null default Set column null by default unless identity Aug 26, 2020
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
@dereuromark dereuromark added this to the 0.13 milestone Aug 26, 2020
@dereuromark
Copy link
Member

dereuromark commented Aug 26, 2020

Sounds good to me. Most will always mention the null topic explicitly anyway in their migrations.
So shouldn't be a big deal.
Any objections from others?

@sitedyno
Copy link

#1718 🏓

@Bilge
Copy link
Contributor

Bilge commented Jan 3, 2023

Looks like you missed

->addColumn('breakpoint', 'boolean', ['default' => false])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants