add support for smallserial alias for postgres #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
|
Docs need to be added for this, but not sure where best to place them. Should I make a new section to describe this behavior, or just append it to column options as a note? |
|
@dereuromark any word on PR? |
dereuromark
approved these changes
Nov 10, 2020
|
Is it worth its own section? Otherwise appending sounds reasonable for now. |
|
@dereuromark done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debated on whether to make this against master or 0.next, and decided for 0.next as this is a breaking chang, albeit a small one.
Closes (properly) #1693
Using the column type
smallintegerwithidentity = truewill produceSMALLSERIALdata type. This mirrors the usage ofbigintegerproducingBIGSERIAL.