Allow specifying template style for create command #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov failing seems like a bug on their end as all lines in this changeset are covered by tests. |
dereuromark
reviewed
Oct 12, 2021
Co-authored-by: Mark Scherer <dereuromark@users.noreply.github.com>
…o feature-template-style
|
Any news on when this will have a release tag? |
|
Any other breaking changes we want to include and ship? |
|
Is this documented? I can't find any reference to If I run
|
dereuromark
reviewed
Nov 30, 2022
| @@ -57,6 +58,8 @@ protected function configure(): void | |||
|
|
|||
| // Allow the migration path to be chosen non-interactively. | |||
| $this->addOption('path', null, InputOption::VALUE_REQUIRED, 'Specify the path in which to create this migration'); | |||
|
|
|||
| $this->addOption('style', null, InputOption::VALUE_REQUIRED, 'Specify the style of migration to create'); | |||
There was a problem hiding this comment.
This creates a BC issue for https://github.com/cakephp/migrations/actions/runs/3583067226/jobs/6028049748 it seems for new release of supporting 0.13
Could we just default to one somewhere maybe? Not having it required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new config option and runtime flag for allowing to specify the template style you want to use, either
changeorup_down, with the former being the default value. This can be used by people who want the older style ofupanddownfunctions over thechangefunction.This PR is against
0.nextdue to breaking changes of:Createconsole class.Closes #2009.