Do not set code when recasting PDOException #2101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2098
The
PDOException
class has the signatureint|string $code
, which makes it incompatible with most other stdlib exceptions that only allowint $code
. While we could probably make a custom exception class or whatever for the recast, I don't think it's worth the hassle, and looking at the DB ecosystem, some amount of it also just drops the code in favor of just using0
(e.g.cakephp/Database
inDatabase/Driver
and have for years that I'm not sure people will really miss it.The PDOException recast has been happening for the entire existence of this project that I'm somewhat risk adverse to remove the recast.