Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass environment to seed from manager #2102

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

martenb
Copy link
Contributor

@martenb martenb commented Aug 23, 2022

No description provided.

@martenb martenb force-pushed the feature/seed-environment branch 2 times, most recently from e931a91 to 21916a5 Compare August 23, 2022 10:47
@martenb martenb requested a review from dereuromark August 23, 2022 10:49
Copy link
Member

@dereuromark dereuromark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MasterOdin
Copy link
Member

MasterOdin commented Aug 24, 2022

@martenb could you rebase this against the 0.next branch instead of 0.x as while I'm not sure how many people have created custom managers, this is still editing the public interface, and so is a BC break.

As part of rebasing, please also add full type hints to all the new methods and such you've added.

@martenb martenb changed the base branch from 0.x to 0.next August 24, 2022 06:22
@martenb martenb force-pushed the feature/seed-environment branch from 21916a5 to d40b220 Compare August 24, 2022 06:22
@martenb
Copy link
Contributor Author

martenb commented Aug 24, 2022

@MasterOdin rebased

Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor nits, and then I think good to merge 👍

src/Phinx/Seed/AbstractSeed.php Outdated Show resolved Hide resolved
src/Phinx/Seed/SeedInterface.php Outdated Show resolved Hide resolved
src/Phinx/Seed/SeedInterface.php Outdated Show resolved Hide resolved
@martenb martenb force-pushed the feature/seed-environment branch from d40b220 to fb5d54d Compare August 24, 2022 17:30
@martenb martenb requested a review from MasterOdin August 24, 2022 17:31
@MasterOdin MasterOdin changed the title Pass environment to seed from manager. Pass environment to seed from manager Aug 25, 2022
@MasterOdin MasterOdin merged commit f067f37 into cakephp:0.next Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants