-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass environment to seed from manager #2102
Conversation
e931a91
to
21916a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@martenb could you rebase this against the As part of rebasing, please also add full type hints to all the new methods and such you've added. |
21916a5
to
d40b220
Compare
@MasterOdin rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor nits, and then I think good to merge 👍
d40b220
to
fb5d54d
Compare
No description provided.