Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Cake 5 #2106

Merged
merged 7 commits into from
Oct 6, 2022
Merged

Update for Cake 5 #2106

merged 7 commits into from
Oct 6, 2022

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Oct 2, 2022

No description provided.

@ADmad ADmad force-pushed the cake5-updates branch 3 times, most recently from 43affda to a1355b6 Compare October 2, 2022 16:29
@LordSimal
Copy link
Contributor

I gotta say I am not really sure why the test for $stm->rowCount() was working with an expected value of 1.
According to https://stackoverflow.com/questions/4694850/pdo-sqlite-query-zero-result-issue PDO Drivers are not really consistent when it comes to returning the correct row count for SELECT queries.
As you can see https://onlinephp.io/c/8a760 the RowCount is always 0 for a SQLite PDO object and a prepared select statement.

@LordSimal
Copy link
Contributor

Had to drop symfony/console:^3.4 support because prefer-lowest installed a version which was not compatible with 8.1 named parameters

@LordSimal
Copy link
Contributor

And now vendor/bin/validate-prefer-lowest told me other required packages can be narrowed down as well...

@LordSimal LordSimal force-pushed the cake5-updates branch 2 times, most recently from 61d19ef to b80fa00 Compare October 2, 2022 18:11
@ADmad ADmad marked this pull request as ready for review October 2, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants