Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable error php.ini directives in GH workflow #2113

Merged
merged 4 commits into from
Oct 9, 2022
Merged

Enable error php.ini directives in GH workflow #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c8282b
Enable error php.ini directives in GH workflow
MasterOdin Oct 7, 2022
4f1aa83
Merge branch '0.x' into actions_errors
MasterOdin Oct 8, 2022
8d97c46
Merge branch '0.x' into actions_errors
MasterOdin Oct 9, 2022
bed2dae
use time_nanosleep over sleep
MasterOdin Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ jobs:
with:
php-version: ${{ matrix.php-version }}
coverage: pcov
ini-values: zend.assertions=1, error_reporting=-1, display_errors=On

- name: Get composer cache directory
id: composer-cache
Expand Down Expand Up @@ -146,7 +147,7 @@ jobs:
with:
php-version: ${{ env.PHP_VERSION }}
extensions: ${{ env.EXTENSIONS }}
ini-values: apc.enable_cli = 1, extension = php_fileinfo.dll
ini-values: apc.enable_cli=1, extension=php_fileinfo.dll, zend.assertions=1, error_reporting=-1, display_errors=On
coverage: pcov

- name: Setup SQLServer
Expand Down
4 changes: 2 additions & 2 deletions tests/Phinx/Console/Command/CreateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public function testExecuteWithDuplicateMigrationNames()

$commandTester = new CommandTester($command);
$commandTester->execute(['command' => $command->getName(), 'name' => 'MyDuplicateMigration']);
sleep(1.01); // need at least a second due to file naming scheme
time_nanosleep(1, 100000); // need at least a second due to file naming scheme

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('The migration class name "MyDuplicateMigration" already exists');
Expand Down Expand Up @@ -181,7 +181,7 @@ public function testExecuteWithDuplicateMigrationNamesWithNamespace()

$commandTester = new CommandTester($command);
$commandTester->execute(['command' => $command->getName(), 'name' => 'MyDuplicateMigration']);
sleep(1.01); // need at least a second due to file naming scheme
time_nanosleep(1, 100000); // need at least a second due to file naming scheme

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('The migration class name "Foo\Bar\MyDuplicateMigration" already exists');
Expand Down