Remove unnecessary PDO test mock classes #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
changed the title
MasterOdin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the comment at the top of
tests/Phinx/Db/Mock/PdoAdapterTestPDOMockWithExecChecks.php, it was only added because of an error that would occur under PHP 5.4 when trying to use$this->getMockForAbstractClass(\PDO::class). Given that we no longer support that version of PHP, we should try to move back to the expected way of doing PHPUnit mocks.I found I could also remove
tests/Phinx/Db/Mock/PdoAdapterTestPDOMock.phpon somewhat similar grounds that it's easy enough to just make a PDO mock via phpunit for the one test it was used.This class is also throwing a fatal error in #2113 and seems easier to kill off this class altogether than try to debug whatever is going wrong there.