Add feature flags to disable some breaking changes #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
|
I still need to write some tests for this, but wanted to get the ball rolling with seeing what people thought of this approach. |
dereuromark
reviewed
Dec 22, 2022
|
So the plan would be to release this as 0.13.4 We will then add docs on how you can already switch those on if you want before they become default in Cake5 Migrations plugin major. 👍 Should work |
|
LGTM but let me add ndm as a reviewer as well since he has been very deep in the whole migrations topic lately. |
LordSimal
approved these changes
Dec 23, 2022
othercorey
reviewed
Dec 23, 2022
othercorey
reviewed
Dec 23, 2022
markstory
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address comments in #2154
A new
FeatureFlagsclass has been introduced that we can use to wrap larger breaking changes, such that end-users may optionally disable them.