Cache created decorated connection #2191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR pulls a commit from the
1.x
branch, where when generating the decorated connection as part ofgetDecoratedConnection
, since it's likely that each call to the function would always just return the same thing anyway currently, just with the overhead of creating a fresh class each time. This is most beneficial to people using the Query Builder.As part of this, I've moved
getDecoratedConnection
to be part of the basePdoAdapter
class as it then allows some code sharing, while creating a newgetDecoratedConnectionConfig
function that gets the individual adapter code.