Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen psr/container version constraint #2237

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

MasterOdin
Copy link
Member

@MasterOdin MasterOdin commented Nov 9, 2023

Closes #2227

cakephp/cakephp@5.0.2 loosened their version constraint of psr/container when then allows us to loosen it as well, allowing both ^1.1 or ^2.0 to be used based on other things you might install alongside phinx.

@dereuromark dereuromark merged commit 900e5ca into 0.x Nov 9, 2023
11 of 12 checks passed
@dereuromark dereuromark deleted the chore-psr-container branch November 9, 2023 19:09
@MasterOdin
Copy link
Member Author

MasterOdin commented Nov 9, 2023

@dereuromark This should not have been merged yet since one of the CI checks is failing from this change. I'm also not sure how best to resolve this, where composer update --prefer-lowest won't install psr/container@^1.1 as it doesn't install the lowest version of transitive dependencies, and one of the transitive dependencies ends up with psr/container@^2.0. This causes dereuromark/composer-prefer-lowest tool to fail.

I suppose a "fix" would be to install the lowest version of a transitive dependency as a devDependency within phinx (at least in the CI check), but that's certainly hacky.

@dereuromark
Copy link
Member

composer is sometimes a bit stupid
62fda40 should make it green again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise psr/container compatiblity
2 participants