Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UUID_BLOB for binary16 #2243

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Use UUID_BLOB for binary16 #2243

merged 1 commit into from
Nov 15, 2023

Conversation

dereuromark
Copy link
Member

Follow #2239

Also needs cakephp/cakephp#17421

@dereuromark dereuromark added this to the 0.15.x milestone Nov 14, 2023
MasterOdin
MasterOdin approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge once the core PR ha also been approved?

@dereuromark
Copy link
Member Author

dereuromark commented Nov 14, 2023 •
edited
Loading

Yes, we need to wait for the core PR to match approval status.
Also, I needed

str_contains(strtolower($column), 'blob')

since the column usually comes in uppercase

but actually

if (($col === 'binary' && $length === 16) || strtolower($column) === 'uuid_blob')

should suffice

@dereuromark dereuromark mentioned this pull request Nov 15, 2023
Merged
@dereuromark dereuromark merged commit 192e7f7 into 0.x Nov 15, 2023
12 checks passed
@dereuromark dereuromark deleted the dereuromark-patch-1 branch November 15, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterOdin MasterOdin MasterOdin approved these changes

@markstory markstory markstory approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.15.x
Development

Successfully merging this pull request may close these issues.
3 participants
@dereuromark @markstory @MasterOdin