Make Abstract{Migration,Seed}::getAdapter return non-null #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2200
Modifies the
getAdaptermethod for theAbstractMigrationandAbstractSeedclasses to always return an adapter, or error if there is not one available. This is a change of behavior forAbstractMigrationas it was documented as nullable before, whileAbstractSeedwould throw a fatal error if the adapter was not set. Now both will return a\RuntimeExceptionif this method is called before an adapter has been set, but it's not expected that this should happen in user code unless they modify the constructor method to call it, but at that point it'd always be null so not sure why anyone would. As such, not considering this a BC break.