Fixing errors when migration name is null #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded PHP (to 8.1) and Phinx (to latest) an ran into some PHP TypeErrors when running our migrations.
We've been using Phinx for a very long time, and have some migration versions in our
phinxlogthat have anullmigration_name since they were ran before there was a migration name column, and apparently that column is nullable.This PR just adds a null coalescing operator in a couple of places that the TypeError was thrown. I've also added a test (based on another existing test, just with the migration_name changed to null) that did hit these TypeErrors (and don't with the code change in place).
We could just update our migrations to use an empty string, or populate the migration names, but figured this might benefit other Phinx users.