Option for addTimeStamps() to use datetime #2273
Conversation
…dTimestamps() on MySQL
|
@cakephp/phinx Any reviews? |
|
Will this be ported to migrations? I wonder if we should make a list of prs to migrate etc |
In a way yes, I'm hoping to update the internals of migrations to use cake's db reflection so we'll inherit the fix made in cake. I can also port this change as is over it should apply. |
Port changes from cakephp/phinx#2273 to the migrations backend. This helps maintain compatibility with phinx.
There was a problem hiding this comment.
We could probably enable this by default and it wouldn't have the largest blast radius, given that not sure how often people are relying on these auto-generated columns having a specific type. We could then add also getting timestamps or datetimes as an option to addTimestamps to help the transition for people who were relying on the timestamp type.
|
I had considered requesting to make it the default since timestamp fields are deprecated in MySQL. But didn't want to add delays to getting the option into the code so I can start using it ;) It should definitely become the default on the next major revision of phinx if it has to wait until then. |
Adds a feature flag to use datetime on MySQL for addTimestamps() function instead of timestamp.
Implements #1635
timestamp columns do not support dates past 2038-01-19 on MySQL