Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysql latest CI workflow #2276

Merged
merged 2 commits into from
May 20, 2024
Merged

Fix mysql latest CI workflow #2276

merged 2 commits into from
May 20, 2024

Conversation

MasterOdin
Copy link
Member

@MasterOdin MasterOdin commented May 20, 2024 •
edited
Loading

PR fixes the latest mysql CI workflow where:

  • Removed the default-authentication-plugin flag, where this was removed in MySQL 8.4 in favor of a new mysql-native-password. However, given that PHP has supported the new auth scheme for 6 years, no real reason to keep using it.
  • Pinned the workflow to use MySQL 8.3 right now, as something about 8.4 has introduced a break in the tests, and want to investigate that without blocking other work for now. Fixing this will be addressed as part of Fix test suite to run against mysql 8.4 #2277.

@MasterOdin MasterOdin changed the title Fix running CI against latest mysql Fix mysql latest CI workflow May 20, 2024
@MasterOdin MasterOdin mentioned this pull request May 20, 2024
Closed
@MasterOdin MasterOdin merged commit 31aa45d into 0.x May 20, 2024
10 checks passed
@MasterOdin MasterOdin deleted the fix-mysql-ci branch May 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MasterOdin