Fix using string primary_key value for sqlite #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
force-pushed
the
fix-sqlite-primary-key
branch
from
9b4e7bb
to
9e9ca7b
Compare
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
MasterOdin
force-pushed
the
fix-sqlite-primary-key
branch
from
9e9ca7b
to
d20e3e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2283
PR fixes a bug for sqlite where if a string value was passed for the
primary_keyoption, then following error would be thrown:Surprisingly, this looks like it's been broken for 4+ years, though I guess not too many people use sqlite and use custom identity columns for primary keys.