Fix quoting DB name when creating/dropping #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jharder <jared.harder@gmail.com> Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
MasterOdin
commented
Jun 4, 2024
| 'CREATE DATABASE `%s` DEFAULT CHARACTER SET `%s` COLLATE `%s`', | ||
| $name, | ||
| 'CREATE DATABASE %s DEFAULT CHARACTER SET `%s` COLLATE `%s`', | ||
| $this->quoteColumnName($name), |
There was a problem hiding this comment.
The upstream patch used $this->quoteTableName which does an escape around any . characters in addition to calling quoteColumnName where it's assuming that it's a separator between schema and table name. Given that database names don't have schema references, better I think to use quoteColumnName directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of cakephp/migrations#717 to phinx which fixed using values that needed being escaped for mysql, but did not fix it for postgres or sqlserver.
I think there is still issues in some other places the DB name can be referenced in being quoted, but they're used within
WHEREclauses within a SQL statement, and the fix there is to rework the queries to be parameterized vs usingsprintf, which can be done in a follow-up PR.