Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting sqlsrv PK name with qualified table name #2306

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Fix setting sqlsrv PK name with qualified table name #2306

merged 3 commits into from
Sep 7, 2024

Conversation

MichaelDesignamite
Copy link
Contributor

Fix for #2305

@MasterOdin
Copy link
Member

Thanks for the PR @MichaelDesignamite, are you able to add a test that covers this bug/fix?

MasterOdin
MasterOdin approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@MasterOdin MasterOdin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up just writing the test myself as I'm looking to get a new release out.

Thanks for putting together this PR. 😄

@MasterOdin MasterOdin changed the title Replace dot in sqlsrv primary key name with underscore Fix setting sqlsrv PK name with qualified table name Sep 7, 2024
@MasterOdin MasterOdin merged commit b5dab99 into cakephp:0.x Sep 7, 2024
14 checks passed
@MasterOdin MasterOdin mentioned this pull request Sep 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterOdin MasterOdin MasterOdin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDesignamite @MasterOdin