Fix compiler warning & thread was not terminated #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kafka Consumer Configs didn't have configurations related to topic.
jiminhsieh
commented
Apr 19, 2018
| @@ -46,7 +46,8 @@ class ConfigureSerializationSpec extends KafkaIntSpec{ | |||
| """.stripMargin | |||
| ), keySerializer, valueSerializer) | |||
|
|
|||
| val _ = KafkaProducer(conf) | |||
There was a problem hiding this comment.
Producer thread will stay in JVM even after finishing the test.
There was a problem hiding this comment.
Here is the picture I recorded from VisualVM.
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 64.85% 65.04% +0.18%
==========================================
Files 16 16
Lines 535 535
Branches 31 31
==========================================
+ Hits 347 348 +1
+ Misses 188 187 -1
Continue to review full report at Codecov.
|
|
Nice one, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.