Feedback fixes from Prod deploy v1.10.0 #225
Merged
+87
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Afani97
force-pushed
the
CU-8685dcrr6_Expand-graphchart-visuals-when-only-two-graph-types-are-selected
branch
from
452b47a
to
2887711
Compare
Afani97
commented
Aug 24, 2023
| {displayStopPurposeTooltips && ( | ||
| <> | ||
| <div ref={setReferenceElement} /> | ||
| <Tooltip |
There was a problem hiding this comment.
This popper tooltip was re-rendering on scroll, which caused the graphs to re-render and provide a bad experience. Here we just want to show the tooltip if we actually need to.
Afani97
commented
Aug 24, 2023
| </Tooltip> | ||
| </> | ||
| )} | ||
| <Line options={options} data={data} redraw={redraw} datasetIdKey={title} /> |
There was a problem hiding this comment.
The redraw flag adjusts the widths of the adjacent graphs, increasing/decreasing depending on the selected graphs the user wants to see.
…en-only-two-graph-types-are-selected
…aph-types-are-selected' into update-pie-chart-styling
Update pie chart styling
…aph-types-are-selected' into add-endpoints-to-prime-cache-list
Expand list of urls for prime caching
…aph-types-are-selected' into update-traffic-stops-tooltips
Update tooltip language and placement
…aph-types-are-selected' into upgrade-node-version
Upgrade node version to 18
Afani97
changed the title
Afani97
force-pushed
the
CU-8685dcrr6_Expand-graphchart-visuals-when-only-two-graph-types-are-selected
branch
from
663e102
to
b0e6721
Compare
Afani97
deleted the
CU-8685dcrr6_Expand-graphchart-visuals-when-only-two-graph-types-are-selected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed:
Preview:
