Skip to content

Commit

Permalink
Fix: Use same Bootstrap version for both Admin and Benefits (#2555)
Browse files Browse the repository at this point in the history
  • Loading branch information
machikoyasuda authored Dec 5, 2024
2 parents b58eb16 + 47e3a32 commit 8fd2c5a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 10 deletions.
5 changes: 1 addition & 4 deletions benefits/core/templates/core/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@
{% endblock preload %}

<link href="https://fonts.googleapis.com/css?family=Roboto:400,500,700" rel="stylesheet" type="text/css">
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.3/dist/css/bootstrap.min.css"
rel="stylesheet"
integrity="sha384-QWTKZyjpPEjISv5WaRU9OFeRpok6YctnYmDr5pNlyT2bRjXh0JMhjY6hW+ALEwIH"
crossorigin="anonymous">
{% include "core/includes/bootstrap-css.html" %}
<link href="{% static "css/styles.css" %}" rel="stylesheet">
<link href="{% static "img/favicon.ico" %}" rel="icon" type="image/x-icon" />

Expand Down
4 changes: 4 additions & 0 deletions benefits/core/templates/core/includes/bootstrap-css.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.3/dist/css/bootstrap.min.css"
rel="stylesheet"
integrity="sha384-QWTKZyjpPEjISv5WaRU9OFeRpok6YctnYmDr5pNlyT2bRjXh0JMhjY6hW+ALEwIH"
crossorigin="anonymous">
2 changes: 1 addition & 1 deletion benefits/templates/admin/agency-base.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
src="https://cdn.jsdelivr.net/npm/jquery@3.6.1/dist/jquery.min.js"
integrity="sha256-o88AwQnZB+VDvE9tvIXrMQaPlFFSUTR+nldQm1LuPXQ="
crossorigin="anonymous"></script>
{% include "admin/includes/bootstrap.html" %}
{% include "core/includes/bootstrap-css.html" %}
{% include "admin/includes/style-admin.html" %}
{% include "core/includes/analytics.html" with api_key=analytics.api_key uid=analytics.uid did=analytics.did %}
{% endblock extrastyle %}
Expand Down
4 changes: 0 additions & 4 deletions benefits/templates/admin/includes/bootstrap.html

This file was deleted.

2 changes: 1 addition & 1 deletion benefits/templates/admin/login.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{% block extrastyle %}
{% comment %} Overriding instead of extending agency-base here to remove jQuery declaration, which admin/login.html includes on its own {% endcomment %}
{% include "admin/includes/favicon.html" %}
{% include "admin/includes/bootstrap.html" %}
{% include "core/includes/bootstrap-css.html" %}
{% include "admin/includes/style-admin.html" %}
{% endblock extrastyle %}

Expand Down

0 comments on commit 8fd2c5a

Please sign in to comment.