Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Docs site theme does not have sufficient color contrast/link contrast #2404

Closed
machikoyasuda opened this issue Sep 25, 2024 · 2 comments · Fixed by #2595
Closed

Docs: Docs site theme does not have sufficient color contrast/link contrast #2404

machikoyasuda opened this issue Sep 25, 2024 · 2 comments · Fixed by #2595
Assignees
Labels
bug Something isn't working documentation [auto] Improvements or additions to documentation

Comments

@machikoyasuda
Copy link
Member

machikoyasuda commented Sep 25, 2024

The Benefits docs site theme, which uses Cal-ITP's default docs theme, is not color contrast sufficient in a few areas:

  • The nav bar color background
  • The footer text
  • The links on white background
  • The links should be underlined or visibly distinguished w/o color
  • Gray comments in code blocks

I believe the changes need to be made upstream, in this repo, https://github.com/cal-itp/mkdocs-template, but I wanted to document the bug in Benefits first.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Run a11y tests
image

Expected behavior

Ideas:

  • Replace the bright blue with Cal-ITP blue for background and links
  • Change the footer to be black on white text
  • Change the links to be underlined by default
image image
@machikoyasuda machikoyasuda added the bug Something isn't working label Sep 25, 2024
@thekaveman
Copy link
Member

The settings initially come from https://github.com/cal-itp/mkdocs-template, but that is only a template repo for creating other repos, so making changes there won't automatically reflect out to all other docs sites.

These are OOTB mkdocs-material styles, but there are a lot of customization options: https://squidfunk.github.io/mkdocs-material/customization/

It would be nice to normalize the look and feel with the app itself.

@thekaveman thekaveman added the documentation [auto] Improvements or additions to documentation label Sep 26, 2024
@machikoyasuda
Copy link
Member Author

machikoyasuda commented Oct 2, 2024

I wanted to see if and how I could get the docs site WCAG 2.0 AA compliant with as little code as possible. Here's how far I got, to fix all the color contrast and link issues:

mkdocs.yml: set up custom css

   palette:
     - media: "(prefers-color-scheme: light)"
-      scheme: default
-      primary: blue
-      accent: amber
+      primary: custom
+      accent: custom
       toggle:
         icon: material/toggle-switch-off-outline
         name: Switch to dark mode
     - media: "(prefers-color-scheme: dark)"
-      scheme: slate
-      primary: blue
-      accent: amber
+      primary: custom
+      accent: custom
       toggle:
         icon: material/toggle-switch
         name: Switch to light mode
@@ -42,6 +40,7 @@ plugins:

 extra_css:
   - https://use.fontawesome.com/releases/v5.13.0/css/all.css
+  - stylesheets/extra.css

docs/stylesheets/extra.css: use cal-itp blue and white, set underlines on links

[data-md-color-scheme="default"] {
  --md-primary-fg-color: #045b86;
  --md-primary-fg-color--light: #045b86;
  --md-primary-fg-color--dark: #045b86;
  --md-footer-fg-color: hsla(0, 0%, 100%, 1);
  --md-footer-fg-color--light: hsla(0, 0%, 100%, 1);
  --md-footer-fg-color--lighter: hsla(0, 0%, 100%, 1);
  --md-footer-bg-color: hsla(0, 0%, 0%, 1);
  --md-footer-bg-color--dark: hsla(0, 0%, 0%, 1);
  --md-code-hl-comment-color: #0071ce;
  --md-typeset-a-color: #000000;
}

a {
  text-decoration: currentColor underline dotted auto;
}

.md-tabs__link {
  opacity: 1;
  font-weight: bold;
  text-decoration: none;
}

Looks like this:
Image
Image

@machikoyasuda machikoyasuda moved this from Todo to Needs shaping in Digital Services Oct 16, 2024
@thekaveman thekaveman moved this from Needs shaping to In progress in Digital Services Dec 17, 2024
@thekaveman thekaveman self-assigned this Dec 17, 2024
thekaveman added a commit that referenced this issue Dec 17, 2024
thekaveman added a commit that referenced this issue Dec 17, 2024
@thekaveman thekaveman moved this from In progress to In review in Digital Services Dec 17, 2024
thekaveman added a commit that referenced this issue Dec 17, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Digital Services Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation [auto] Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants