Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reCAPTCHA: Remove icons from media item templates #2538

Closed
Tracked by #2537
machikoyasuda opened this issue Nov 26, 2024 · 2 comments · Fixed by #2564
Closed
Tracked by #2537

reCAPTCHA: Remove icons from media item templates #2538

machikoyasuda opened this issue Nov 26, 2024 · 2 comments · Fixed by #2564
Assignees
Labels
front-end HTML/CSS/JavaScript and Django templates

Comments

@machikoyasuda
Copy link
Member

machikoyasuda commented Nov 26, 2024

The main goal of this ticket is to simply remove icons and icon files from these pages of the flow:

  • Eligibility Start: online account icon, contactless card icon
  • Enrollment: contactless card icon
  • Delete unused icon files
  • Don't forget CalFresh alert box page

The icons are included in an includes like this - media-item.html - and removing this code will remove the icons from the page:

    <div class="media-line">
        {% block icon %}
        {% endblock icon %}
    </div>

There is probably some template refactoring that could be done as a result of the removal of icons in the designs (like renaming "media-item" or perhaps getting rid of it entirely, but that doesn't necessarily have to be a part of this ticket. Giving this ticket a rating of 1.

@machikoyasuda machikoyasuda changed the title Remove icons from media item templates. reCAPTCHA: Remove icons from media item templates. Nov 26, 2024
@machikoyasuda machikoyasuda changed the title reCAPTCHA: Remove icons from media item templates. reCAPTCHA: Remove icons from media item templates Nov 26, 2024
@thekaveman thekaveman added the front-end HTML/CSS/JavaScript and Django templates label Nov 26, 2024
@angela-tran angela-tran moved this from Todo to In progress in Digital Services Dec 4, 2024
@angela-tran angela-tran moved this from In progress to In review in Digital Services Dec 5, 2024
@thekaveman
Copy link
Member

Closed by #2564

@github-project-automation github-project-automation bot moved this from In review to Done in Digital Services Dec 6, 2024
@machikoyasuda
Copy link
Member Author

I think this issue didn't get closed automatically b/c the PR got merged into a separate branch, not into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants