Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove unnecessary template code #1674

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

machikoyasuda
Copy link
Member

closes #1672

What this PR does

The new Figma designs eliminated the text preceding CTAs on all pages of the site, like these:
image
image

This PR removes the help_text (used on the Eligibility form CTA, a8a6c63) and the call-to-action-text (used on Eligibility Start) from the templates. It also removes the CSS classes that were necessary to get the mobile version to flip order from the Desktop mode.

@machikoyasuda machikoyasuda requested a review from a team as a code owner August 16, 2023 22:14
@machikoyasuda machikoyasuda self-assigned this Aug 16, 2023
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Aug 16, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@machikoyasuda machikoyasuda merged commit 9d97a08 into dev Aug 21, 2023
@machikoyasuda machikoyasuda deleted the refactor/1672-base-cleanup branch August 21, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Remove call-to-action-text, help-text
3 participants